keepassium / KeePassium

KeePass-compatible password manager for iOS
https://keepassium.com
Other
1.2k stars 103 forks source link

Password Generator separator breaks ui #360

Closed Ironwally closed 7 months ago

Ironwally commented 7 months ago

Description The Gui of the password generator is completely filled with a password and scrolling is no longer possible making it impossible to change the password generator settings anymore.

How to reproduce Steps to reproduce the behavior:

  1. Open App
  2. Open Password Generator
  3. Open Password Generator Settings
  4. Go to Passphrase mode
  5. Put amount of words on max
  6. Set separator to something very VERY long. (long enough for the password to cover your entire screen), remember it is repeated the amount of words - 1
  7. Voilà, your screen should now be filled with one big password and the setting to change this can no longer be reached.

Expected behavior No matter how big password, screen is still scrollable and therefore settings to change it are still reachable.

Screenshots IMG_1903 IMG_1904

Environment:

keepassium commented 7 months ago

Set separator to something very VERY long.

But why?

Ironwally commented 7 months ago

I wanted to see how far I could push the entropy

Ironwally commented 7 months ago

Maybe the possibility to reset the password generator settings from the app settings, could work as an easy fix agains any problems that come up with the password generator.

keepassium commented 7 months ago

Thank you for the clarification. As a general rule, "just avoid holding it in that way" :)

I have also limited the max height of the password label to 50%. This is more of a guardrail, though. The text gets truncated without any indication, which may cause confusion. Doing this properly would require either a scrollbar or a gradient, but this is too much complexity for such a rare edge case. Basically, the app will just leave enough of controls visible that the user can return to more sensible settings :)

Ironwally commented 7 months ago

thanks for the fix 🙏