search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.78k stars 188 forks source link

When I do custom login fields, the URL saved is wrong (iframe URL is not saved) #1238

Open z-Wind opened 3 years ago

z-Wind commented 3 years ago

Expected Behavior

Custom login fields match right URL and KeePassXC-Browser get the right entry in the KeePassXC

Current Behavior

After doing custom login fields, It saves wrong url: "https://odc.officeapps.live.com", and can not link the entry I created. The URL of entry is "https://onedrive.live.com/about/en/signin/" But when I change the URL of entry to "https://odc.officeapps.live.com", it works.

Steps to Reproduce (for bugs)

  1. link: https://onedrive.live.com/about/en/signin/
  2. create an entry in KeePassXC, and the URL of entry is "https://onedrive.live.com/about/en/signin/"
  3. KeePassXC-Browser does not show any data from KeePassXC
  4. do custom login fields, and find that the URL saved is "https://odc.officeapps.live.com"

Debug info

KeePassXC - 2.6.4 KeePassXC-Browser - 1.7.6 Operating system: Linux x86_64 Browser: Chrome/Chromium 88.0.4324.182

varjolintu commented 3 years ago

They are using iframe from the odc subdomain for the login dialog. Lets see if we can force to use the main window URL instead.

varjolintu commented 3 years ago

When thinking this through, this is not actually a bug. Because the site has a different subdomain for the login dialog, you should use https://live.com as your entry URL. Also, using Custom Login Fields is not necessary for the page.

z-Wind commented 3 years ago

But I can not fill out the login dialog by context menu. That's why I use Custom Login Fields. If someone do not know the right url https://live.com, he would think that KeePassXC-Broswer does not work because the url of the browser is https://onedrive.live.com/about/en/signin/

droidmonkey commented 3 years ago

Yah I think what he's saying is that he chose login fields in the iframe but the extension still used the address bar url when saving those credentials.