Open ThePythonicCow opened 6 years ago
I do prefer LastPass' behaviour (the last time I used it), where generated passwords are saved anyways whether it's actually submitted in the registration form. When I switched to KeePassXC, I was expecting the password generator's Copy
and Fill & copy
actions to save the password along with a best guess name/URL which is then turned into the proper entry as per the current procedure.
It's saved me a few times on the rare occasions where the browser extension fails to capture the form data or I when forget to acknowledge the prompt. Searching for the site name + timestamp usually works.
@XA21X If you want to make sure KeePasXC remembers the changed credentials, a safer way is to use the context menu and select Save credentials
. It forces the update even if the submit detection fails (Ajax can do this, the support is not perfect).
However, the context menu should be only used from the new password field until https://github.com/keepassxreboot/keepassxc-browser/pull/256 is merged.
This seems related: on Firefox 66, KeePassXC 2.3.4, and KeePassXC Browser 1.3.2, updating a password with the dialog popup most of the time doesn't actually do anything with the database.
Even when confirming with KeePassXC that yes, I actually want to update a password in the database, it still doesn't update and it has to be updated manually.
@TheGoddessInari Does current Firefox stable work correctly? We don't officially support Beta or Nightly releases because there can be various of changes in the JavaScript API's and we don't have the manpower to track every one of them.
Have you tried if the current snapshot builds have the same issue? You can download them from https://snapshot.keepassxc.org/.
@varjolintu I've tried with Firefox 65 stable release and snapshots separately, same behavior.
@TheGoddessInari So after a credential update (and the confirmation) the database doesn't event show that is has been modified? Or when you close it, it doesn't say you have any non-saved changes? Also, just to make sure, do you have two ID's with the same name in your extension?
@ThePythonicCow There's finally some improvements coming to this with #351.
Don't mean to necro-post, but this issue seems to still be around to this day — all PRs linked to this issue have been merged, so I wonder if there is any update on this issue or it has been put aside for specific reasons / technical limitations. Thanks in advance for any update
@edo0 With the new KeePassXC 2.7.0 the extension will launch KeePassXC's password generator instead, so there no longer will be any improvements to the extension password generator. If the page itself escapes our submit detection, a new issue should be created for it.
@varjolintu Thank you very much for the good news!!
When I have an existing, password protected, account on some website, where that website and login credentials are known to KeePassXC, then I expect that when I am change that password, using the KeePassXC Password Generator to make a nice new random password, that there will be someway to ensure that that new password is saved to the KeePassXC database, updating the password it has saved for that website.
I can find no way whatsoever to make this happen just from within the Browser interface.
I have to open KeePassXC itself, in a separate window, and update the record for that website to have the newly generated password. If I forget to do so, before closing the KeePassXC Password Generator popup in the browser, then my new password for that website is lost forever.
I would like to use KeePassXC to update my passwords on dozens of websites, and it would be much easier to do so, if I could just work within the browser, rather than copying newly generated passwords back and forth between KeePassXC itself (to get it into an updated KeePassXC record) and the admin page for my account on each corresponding website.
The way it is now, for me, is dangerous -- a high risk of losing a newly generated password if I am not careful.
I am using KeePassXC 2.3.3 with the KeePassXC-Browser 1.1.13 Add-on in Firefox 60.0.2 on Gentoo Linux with the /usr/local/bin/keepassxc-proxy proxy.
The particular site I have been playing around the most with this, trying to see if I was missing some user step (if I am ... I'm still missing it) was my Zerohedge.com account, as that's not a critical account for me, and they have quite functional password recovery mechanisms. However every site I've tried this on is the same way. I do have a critical account at one website (an email service for a critical email account of mine) that, until recently, had an essentially impossible and broken password recovery mechanism ... so I am perhaps more sensitive than most to risks of losing an account's password when trying to update it.
My testing is typically when I have the KeePassXC application already opened and running, with its database unlocked, and the above stated proxy running, and with my being able to login to the test website (such as Zerohedge) using the existing login name and soon to be obsolete password obtained from KeePassXC using the (quite nice) login form recognition and field data entering of KeePassXC. Then I go to my account login page for that website, and endeavor to change my password there. The newly created password never ends up back in the KeePassXC database, and is lost forever, unless I manually also enter that new password directly into "Edit entry" screen for that account in the KeePassXC application and click Apply or OK for that screen.
If the above normally works better than this, for most users, on most systems, suggesting that there is something "special" about my system, then I may be able to assist in debugging the problem, if given some specific questions, as I am an ancient Unix/Linux kernel/utilities hacker.
P.S. -- This may actually be a nearly impossible expectation on my part. For some websites, I have multiple login accounts, and without some serious UI and serious logic hacking, the code that was generating a new random password in the browser (even if using the KeePassXC Password Generator) would, perhaps, not know which one of my several login accounts for that website should have its KeePassXC stored password updated. If that is the case, then I recommend == Removing == the interface to the KeePassXC Password Generator in the Browser add-on, as it's an invitation to shoot one's self in the foot (to set some account's password to something that will be immediately and forever after lost.) This in particular would mean == Removing == the "Show Password Generator Icons" option from the KeePassXC context menu for login credential fields, and == Removing == the "Activate password generator" option from the Preferences for this KeePassXC-Browser 1.1.13 Add-on. If the best that can be done with this browser add-on password generator interface is to make it much easier to lose knowledge of your password(s) for a website, then it would be better to not have that interface. I certainly to not know this code well enough to know if this speculation applies here.