keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.77k stars 188 forks source link

On Successful "Reload", Automatically Do a "Redetect Login Fields" #2011

Open xenotropic opened 1 year ago

xenotropic commented 1 year ago

Expected Behavior

This is a low-priority (but probably easy!) feature request. Right now, if KeepassXC is not running, KeepassXC-Browser's pop-up will offer to "reload". If this is done successfully, then the pop up changes to "redetect login fields". The feature request is to, on a successful data reload, automatically do that "redetect login fields" behavior. If the user just clicked "reload", then it seems almost certain that they are trying to log into a site; I cannot imagine a situation when a user reload the database and would not want to "redetect login fields". Whatever time it might take to redetect login fields seems very likely to always be shorter that the time for the user to have to click the button again.

You might consider making this an option at first and then make it default behavior later just in case there's some reason not to do it.

Current Behavior

After successful database reload, KeepassXC-browser asks "redetect login fields".

Possible Solution

This is of course not a super important feature -- just trying to save users a mouse click -- but it annoys me every day, and why not have better UI.

Whether or not you implement, thanks devs for making great open source software!

varjolintu commented 1 year ago

That should be already automatic, but let me check if something is still broken.

If there's a Username Icon visible, clicking that will do the job, but I assume you want to run "Redetect login fields" because that icon is not visible at all.

xenotropic commented 1 year ago

I'm not sure what username icon that would be. Just to be clear (and in case I'm missing something) this is what I'm seeing for "reload"

image

and then I open KeepassXC and its database, click "reload" and this is what it looks like with "redetect login fields"

image

Also to be clear this is not an issue when the KeepassXC database is closed, but only when the entire KeepassXC application is closed; and/or the database connection is dropped. The latter seems to be the case most mornings when I arrive at my computer, which I don't know why that happens (something must timeout?); but other than the fact that I have to to this double-click it doesn't really matter much.