keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.76k stars 187 forks source link

browser extension connection problem after updating firefox to version 122.0 #2091

Closed gica3618 closed 9 months ago

gica3618 commented 9 months ago

Current Behavior

After updating firefox to version 122.0, the keepassxc browser extension is unable to connect.

Steps to Reproduce (for bugs)

  1. update firefox (snap) to version 122.0
  2. attempt to connect the browser extension

As a test, I reverted to firefox version 121.0.1. Then, the extension works fine. Other things I tried:

Debug info

KeePassXC - 2.7.6 KeePassXC-Browser - 1.8.11 Operating system: Ubuntu 22.04.3 Browser: Firefox Snap for Ubuntu, version 122.0

Some output from sudo strace -f -p $(pgrep firefox) 2>&1 | grep keepass is here: strace_output.txt Picture of the weblog console: Screenshot from 2024-01-24 12-20-40

varjolintu commented 9 months ago

This is a known issue. Sometimes after Firefox update the Native Messaging gets broken. The only solution for now is to restart both KeePassXC and Firefox. Try that first. If the problem is in the Snap package itself, I'd recommend using a normal .deb package instead.

gica3618 commented 9 months ago

Thank you @varjolintu. Sorry for my ignorance, but if you say "restart", you simply mean quitting both KeePassXC and Firefox and opening again, right? That doesn't help, the extension can still not connect. Or do I need to type specific commands in the terminal to restart?

jheld commented 9 months ago

Agreed, I have restarted both several times and rebooted the machine twice. Nothing works.

varjolintu commented 9 months ago

A normal restart should work. However, if this is something that Snap itself has broken in their Firefox package, there's nothing we can do about it. I haven't investigated the issue yet.

dkd-kaehm commented 9 months ago

FYI: https://www.mozilla.org/en-US/firefox/122.0/releasenotes/

Firefox now supports creating and using passkeys stored in the iCloud Keychain on macOS.

Following solves the issue temporary:

sudo snap revert firefox
firefox --allow-downgrade &
oidarnam commented 9 months ago

I am having the same problem after update yesterday to Firefox 122.0 using https://ppa.launchpadcontent.net/mozillateam/ppa/ubuntu/

Restarted both applications...no luck. Apparently, Mozilla broke something. All the other browsers I have using keepassxc-browser continue to work.

oidarnam commented 9 months ago

I am having the same problem after update yesterday to Firefox 122.0 using https://ppa.launchpadcontent.net/mozillateam/ppa/ubuntu/

Restarted both applications...no luck. Apparently, Mozilla broke something. All the other browsers I have using keepassxc-browser continue to work.

I installed the .deb from varjolintu's provided link and everything is working again. Thank you!

So on closer investigation, apparently I did have Firefox snap. The ppa wasn't installing the deb package. Apt says I have the latest Firefox snap. I specifically used the ppa to install the deb because of keepassxc connection issues with snap. I'd been thwarted!

antiftw commented 9 months ago

Having the same issue, I have created a bug-report in Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1876495

varjolintu commented 9 months ago

Having the same issue, I have created a bug-report in Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1876495

I doubt this bug has anything to do with Mozilla. This is probably because of Ubuntu's Snap and their Native Messaging implementation.

antiftw commented 9 months ago

Hmm then why did it work without issues before the update to 122.0? I have always used the Snap version, and it still works for me in Chromium which is also installed using Snap.

DandyDiamond commented 9 months ago

I am getting the same problem.

The Snap of Firefox was updated to 122.0 and KeePassXC no longer connected. I read that Mozilla were now doing a .deb package that was no longer contained in a sandbox and easier to integrate with, so by chance, went to the same link as varjolinu shows above and downloaded and installed Firefox 122.0 .deb package. KeePassXC Browser will still not connect to and open database: _Key exchange was not successful. Cannot connect to KeePassXC. Check that browser integration is enabled in KeePassXC settings.__

I have removed and reinstalled the Browser Extension and while trying to sort things out, found that in Advance Settings of KeePassXC there is a 'custom browser configuration location'. I found that the .mozilla config file is now in ~/.mozilla/native-messaging-hosts and not in ~/.config/mozilla/native-messaging-hosts, so edited that. Unfortunately, that has made no difference.

EDIT: OS is Ubuntu 22.04

varjolintu commented 9 months ago

With Ubuntu, please also check if any AppArmor settings has been changed: https://github.com/keepassxreboot/keepassxc-browser/wiki/Troubleshooting-guide#6-apparmor-with-ubuntu

antiftw commented 9 months ago

@varjolintu Seems you were partly right. The bug-report I created has been closed as a duplicate, while referring to another bug-report that does have something to do with the Native Messaging:

https://bugzilla.mozilla.org/show_bug.cgi?id=1876447

They are working on resolving it:

Thanks for the bug report. The messaging portal patch is indeed part of the snap and not upstream at this point. The patch was refreshed to apply cleaning to 122 and rebased at the same time on the current phabricator version which made it use a new dbus method. We didn't notice that this method hadn't been backported to the Ubuntu 22.04 portal package. We are working now on reverting the patch to not depends on the new method.

droidmonkey commented 9 months ago

So glad snaps are robust and healthy ecosystem not filled with app specific workarounds and silly fake sandboxing. /s

DandyDiamond commented 9 months ago

I edited AppArmor.d with the modifications in your link, however, restarted computer (aa-enforce was missing). Then Firefox refused to load any tabs. (I will sort that later)

Does it matter where in the usr.bin.firefox file the modifications are made?

Not so 'worried' now after getting @antiftw response.

Thank you all! (I can be very dangerous at the Keyboard, so these messages help with my confidence!! :lol)

paulrouget commented 9 months ago

FYI, the bug has been identified (Snap), and Canonical is on it.

https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2051188

https://bugzilla.mozilla.org/show_bug.cgi?id=1876447

gica3618 commented 9 months ago

Just updated Firefox Snap to the newest version, and it works again!

hlongmore commented 3 months ago

For anyone who arrives here from a search engine, and is running Ubuntu and Chrome, I found this info from the Troubleshooting Guide really useful:

After finding the org.keepassxc.keepassxc_browser.json check the path variable inside it. It should point to the exact location to the KeePassXC binary.

On my system, after downloading and launching from the latest KeePassXC AppImage, I needed to update the new AppImage file:

~/.config/google-chrome/NativeMessagingHosts$ diff org.keepassxc.keepassxc_browser.json org.keepassxc.keepassxc_browser.json.bak 
8c8
<     "path": "/home/hlongmore/keepassxc/KeePassXC-2.7.9-x86_64.AppImage",
---
>     "path": "/home/hlongmore/keepassxc/KeePassXC-2.6.6-x86_64.AppImage",

and then restart Chrome.