search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.73k stars 182 forks source link

Passkeys are saved to default group even when custom default group is configured #2153

Open snwflake opened 6 months ago

snwflake commented 6 months ago

Expected Behavior

Passkeys should either be saved to the default group set by the user for password credentials or it might benefit from having an alternative option dialogue to define a separate group for saving them.

Current Behavior

Saving a Passkey ignores the value set by a user in Saving Credentials -> Default group to save new passwords and saves it to KeePassXC-Browser Passwords regardless of what group the user specified in aforementioned option.

Possible Solution

Either apply the custom group name to saving the Passkey to said group, or introduce another text field in order to provide a separate group to save Passkeys in.

Tangent

I am fully aware that this is probably obsolete, once keepassxcreboot/keepassxc#10408 gets merged, but this is a bug regardless...maybe

Steps to Reproduce (for bugs)

  1. Set new default group for entries in the extension
  2. Create new Passkey

Debug info

KeePassXC - 2.7.7 KeePassXC-Browser - 1.9.0.2 Operating system: Linux x86_64 Browser: Chrome/Chromium 122.0.0.0 (Brave)

varjolintu commented 6 months ago

Yes, I'm aware that option is not respected now. I think a separate option field could be used for this. I would assume users would like to use a different group for passkeys if possible.

varjolintu commented 3 weeks ago

This change is required to the KeePassXC side for the feature: https://github.com/keepassxreboot/keepassxc/pull/11260