search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.78k stars 188 forks source link

Options: Unclear Connect button in Connected Databases tab #2241

Closed Chealer closed 5 months ago

Chealer commented 5 months ago

The extension's options contain a Connected Databases tab which ends with a button. This button has no tooltip, Connect as only label, offers no feedback and is part of an undocumented tab.

Possible Solution

Implementing at least one of the following would mitigate/solve:

  1. Labelling clearly or adding a tooltip
  2. Documenting options
  3. Adding feedback

Debug info

KeePassXC-Browser - 1.9.0.5 Operating system: Microsoft Windows Browser: Mozilla Firefox

varjolintu commented 5 months ago

The feedback for this is added to Protocol V2 draft that also listens to the current database state.

Chealer commented 5 months ago

4b55cc958385edf268ee9000650d93f21e943bf1 attempts to address this by defining a connectButtonTitle label:

Connect current active database to KeePassXC-Browser.

Unfortunately, while this may clarify a bit, this is far from solving the issue. What "current active database" means is very unclear.

Note that such labels are not terminated with periods.

varjolintu commented 5 months ago

"Current active database" cannot be any more clear than this. It's the active database tab in KeePassXC.

I decided that those labels are terminated with periods, so those would be possible to use elsewhere later. I'm not going to make changes just because some user is not happy. FY, there's no specification for how to terminate titlesI: https://html.spec.whatwg.org/#the-title-attribute