search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.78k stars 188 forks source link

Extract object from proxy before posting message to extension #2280

Closed edo-bari-ikutsu closed 4 months ago

edo-bari-ikutsu commented 4 months ago

In some web page that supports passkey (ex. https://misskey.io/), public key object is passed as proxy, not plain object. Ploxy cannot be passed from the page script to the extension script with dispatchEvent method in postMessageToExtension function in passkeys.js, thus authentication with passkey fails.

In this PR, extraction from proxy to plain object before passing with dispatchEvent method is added.

edo-bari-ikutsu commented 4 months ago

With further investigation, this issue is mainly due to implementation of Misskey itself, not of KeePassXC browser extension. I will try to propose the fix to the Misskey community, thus wait the discussion and merge of this PR for a while.

edo-bari-ikutsu commented 4 months ago

Fix of misskey itself about this issue has been merged (https://github.com/misskey-dev/misskey/commit/3b075c9c441e8fe2d7446a7201cd1950437ba0b6), and fix of KeePassXC-Browser is not needed now. Thus I have closed this PR.