Fails to fill out password form fields on XHTML pages - Githubissues

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension

GNU General Public License v3.0

1.78k stars 188 forks source link

Fails to fill out password form fields on XHTML pages #2313

Closed CharlemagneLasse closed 3 months ago

CharlemagneLasse commented 3 months ago

Expected Behavior

Filling out the form works

Current Behavior

username is filled out but password is not filled out

Possible Solution

change the check if (combination.password && combination.password.nodeName === 'INPUT') { to something which is case-insensitive if (combination.password && combination.password.nodeName.toUpperCase() === 'INPUT') {
OR revert the change which introduced the regression (83d536698dcba227a22bea93100062b464637e83) from PR #2259

Steps to Reproduce (for bugs)

create page with content type XHTML and serve with Content-Type: application/xhtml+xml;charset=utf-8
try to auto-fill password
see that only the username is filled out but not the password (because its combination.password.nodeName is input and not INPUT)

Debug info

KeePassXC - 2.7.4 KeePassXC-Browser - 1.9.2 Operating system: Linux Browser: Firefox 115.14.0esr (64-bit)

varjolintu commented 3 months ago

This is regression from: https://github.com/keepassxreboot/keepassxc-browser/pull/2287