search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.78k stars 188 forks source link

Allow moving Credential Banner somewhere else (to the bottom?) #2327

Closed stdedos closed 1 month ago

stdedos commented 3 months ago

Expected Behavior

https://www.matkahuolto.fi/ site uses notifications which flow from the top for "wrong password" and "email sent" (password recovery).

I expect to be able to move the Credential Banner, so can check the top of the page, without dismissing it.

Current Behavior

Credential Banner is hard-coded to the top

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Debug info

KeePassXC - {VERSION} KeePassXC-Browser - {VERSION} Operating system: Mac/Win/Linux Browser: Chrome/Firefox/Vivaldi/Chromium

varjolintu commented 3 months ago

What modal are you talking about here?

stdedos commented 3 months ago

image

varjolintu commented 3 months ago

Ah, the Credential Banner.

dilpreetsio commented 1 month ago

The behavior is similar with bitwarden as well, its due to the z-index of the banner. We can move it to bottom but that may cause issues with websites which show the toast at the bottom.

We can allow the user to may be move the banner to bottom or top by adding a button. What do you think @varjolintu ?

varjolintu commented 1 month ago

@dilpreetsio That's exactly my idea, but I haven't decided about the UI/UX what could be the most useful thing to do here. I might be in favor or some small arrow bar/selection/checkbox instead of a normal button.

dilpreetsio commented 1 month ago

The ui part is a bit tricky, but having a small arrow instead of a button sounds good.