keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.74k stars 183 forks source link

Brave macOS integration not working #2328

Closed agowa closed 1 month ago

agowa commented 1 month ago

Expected Behavior

  1. The KeePassXC browser plugin connecting to KeePassXC also for Brave on macOS
  2. The Troubleshooting guide mentioning Brave for macOS

Current Behavior

Possible Solution

  1. Improve Troubleshooting and debugging instructions in the wiki for Brave (and in this case Brave on macOS).
  2. Investigate what causes this issue, probably something permission or isolation related in macOS - I'd guess.
  3. Maybe it's also an architecture mismatch issue, as the KeePassXC browser plugin reports the OperatingSystem/Architecture incorrectly as MacIntel instead of something like MacM3/MacArm/...

Edit: When I try to look for a file similar to ~/Library/Application Support/Chromium/NativeMessagingHosts but for Brave on my system I neither have a folder like ~/Library/Application Support/Brave nor ~/Library/Brave, so maybe that is the issue? And it is a bug of their specific build?

Steps to Reproduce (for bugs)

  1. Install KeePassXC
  2. Install Brave
  3. Enable Browser integration in KeePassXC and tick the option for Brave
  4. Install the Brave browser extension from: https://chromewebstore.google.com/detail/keepassxc-browser/oboonakemofpalcgghocfoadofidjkkk
  5. a. Try to connect the extension to KeePassXC by using the "Connect" button on the extensions "Connected Databases" page. b. Just hit the "Reconnect" button in the extensions tooltip multiple times to get the hint about the Troubleshooting page.

Debug info

About info of KeePassXC:

KeePassXC - Version 2.7.9
Revision: 8f6dd13

Qt 5.15.11
Debugging mode is disabled.

Operating system: macOS 14.6
CPU architecture: arm64
Kernel: darwin 23.6.0

Enabled extensions:
- Auto-Type
- Browser Integration
- Passkeys
- SSH Agent
- KeeShare
- YubiKey
- Quick Unlock

Cryptographic libraries:
- Botan 3.1.1

About info of the Browser Plugin:

KeePassXC - unknown
KeePassXC-Browser - 1.9.3
Operating system: MacIntel
Browser: Chrome/Chromium 128.0.0.0

MacOS Hardware Info:

Hardware Overview:

  Model Name:   MacBook Pro
  Model Identifier: Mac15,7
  Model Number: Z1AG000FBD/A
  Chip: Apple M3 Pro
  Total Number of Cores:    12 (6 performance and 6 efficiency)
  Memory:   36 GB
  System Firmware Version:  10151.140.19
  OS Loader Version:    10151.140.19
  Serial Number (system):   ********
  Hardware UUID:    *****
  Provisioning UDID:    ********
  Activation Lock Status:   Disabled

System Software Overview:

  System Version:   macOS 14.6.1 (23G93)
  Kernel Version:   Darwin 23.6.0
  Boot Volume:  Macintosh HD
  Boot Mode:    Normal
  Computer Name:    mac001
  Username: user001
  Secure Virtual Memory:    Enabled
  System Integrity Protection:  Enabled
  Time since boot:  3 days, 14 hours, 54 minutes

Java script console output after hitting "Connect" on the "Connected Databases" page:

[Error keepass.js:313] KeePassXC-Browser - 5: Cannot connect to KeePassXC. Check that browser integration is enabled in KeePassXC settings.

Operating system: Mac Browser: Brave (Version 1.69.153 Chromium: 128.0.6613.85 (Official Build) (arm64))

varjolintu commented 1 month ago

Try enabling all three, Chrome, Chromium and Brave support in KeePassXC. It's a known issue that Brave tends to use settings from incorrect folder. This issue is probably also a duplicate.

varjolintu commented 1 month ago

Try enabling all three, Chrome, Chromium and Brave support in KeePassXC. It's a known issue that Brave tends to use settings from incorrect folder. This issue is probably also a duplicate.

With macOS you can try using opensnoop to detect the correct folder: https://github.com/keepassxreboot/keepassxc-browser/wiki/Troubleshooting-guide#3-check-if-keepassxc-proxy-is-launched-and-running

agowa commented 1 month ago

Hi, you're right. They're using the wrong path. They're using the Google Chrome path. When I looked at their ticket to report this issue I found this ticket: Problem creating NativeMessagingHosts directory

Probably nothing KeePassXC can do then besides maybe extending or rewording the mention of brave using the chrome path within the Troubleshooting Guide to something that doesn't confuse a reader to think it is outdated and only applied before the dedicated Brave option was added to the GUI. As I noted already in the initial post I at least thought it no longer applies because of this dedicated option in the GUI existing...