keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.78k stars 188 forks source link

Add support for draggable banners #2359

Closed varjolintu closed 1 month ago

varjolintu commented 1 month ago

Adds a grab cursor when hovering on Credential or Custom Login Field banner, and allows user to move it to the bottom, or back to the top. If the credential or group selection dialog is open while dragging, its position is changed as well.

Known issues: The dragging animation is not visible if dragging is canceled, or dragged to the same position where the banner already is. I couldn't find a reliable way to do that. The best solution was to disable the animation for good.

Banner on top (default):

Screenshot 2024-10-06 at 22 19 11

Banner on bottom (after dragging):

Screenshot 2024-10-06 at 22 19 16

Fixes #2327.

droidmonkey commented 1 month ago

This works well but the banner showed up on the top of the page immediately after a refresh (ie, the banner being dragged to the bottom is not remembered)

varjolintu commented 1 month ago

This works well but the banner showed up on the top of the page immediately after a refresh (ie, the banner being dragged to the bottom is not remembered)

The original idea was that this dragging is just temporary and done when it's needed. Of course we could just remember the state or add a separate option for remembering it. What do you think?

droidmonkey commented 1 month ago

Keep the drag, its a neat shortcut. We should remember the "last used state" though.

varjolintu commented 1 month ago

Added a setting so the position will be remembered even after browser restart.