search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.76k stars 187 forks source link

Drop hot key customization options #389

Open rugk opened 5 years ago

rugk commented 5 years ago

You currently provide a custom way to adjust hot keys of your extension.

Starting with Firefox 66 Firefox will provide a built-in way of doing so (German article) and thus you can IMHO drop your own customization options in /options/shortcuts.html.

AFAIK other browsers like Chrome/ium already support that customization as a built-in feature too, so there is no need to reimplement that in your extension anymore.

varjolintu commented 5 years ago

Yes, I'm aware of that. When doing to feature there was no public roadmap for the feature. It's good to know official support is soon coming.

varjolintu commented 5 years ago

The important part here is that Firefox versions 60-65 support the API but don't have the feature built-in. This includes Firefox ESR which is based on version 60.

rugk commented 5 years ago

Yes, of course you do not have to do it now. Or you maybe detect the FF version and show/hide the feature programmatically…

varjolintu commented 5 years ago

I'll make the fix before Firefox 66 is released :) The version comparison function already exists.

rugk commented 5 years ago

Yeah, with WebExtension APIs such a version comparison is also easy… :smile:

varjolintu commented 5 years ago

I'm still keeping the new dialog for configuring keyboard shortcuts feature visible for Firefox 66 and newer because for some reason Mozilla did not implement a URL that could go straight to the shortcut settings. Instead you must go to about:addons, then click the gear icon and open the page manually. Not so user friendly.

rugk commented 5 years ago

Okay, opened an issue for that: https://bugzilla.mozilla.org/show_bug.cgi?id=1538451

rugk commented 5 years ago

Now status in the issue:

"design-decision-approved"

As far as I see, this looks good. It has prio 5, however, so they accept contributions on this issue.

varjolintu commented 2 months ago

Dropping by to comment that at least there's something happening in the ticket after a few years.