search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.77k stars 187 forks source link

Use title of the web page rather than url as title for the entry when creating a new entry in the database #662

Open metaphys opened 5 years ago

metaphys commented 5 years ago

Expected Behavior

Since the url get saved in the URL field, it would be nice to save the title of the webpage as title of the entry. Furthermore when saving entry for some administration page without domain name (e. g. routeur/switch) it would make much more sense as title to have a device name instead of some https://192.168.X.X/login entry

Current Behavior

For now the url get save both as url and title for the entry

KeePassXC - 2.5.0 KeePassXC-Browser - 1.5.3 Operating system: Linux x86_64 Browser: Mozilla Firefox 68.0

droidmonkey commented 5 years ago

I agree with this!! At least the webpage title up to the first "-".

metaphys commented 5 years ago

I had a quick look at the code. I'm afraid that I don't know how to that. Also something to take into consideration depending on how the extension is selecting entry in the db: If the browser extension is using title to identify single entry in the db, be careful not to recreate all old entry because we change what we put in the title field

varjolintu commented 5 years ago

It's actually very easy addition to the extension, but we need to support it also in KeePassXC side, so changes are needed.

varjolintu commented 3 years ago

This is an old feature request, but I'd like to have it done. The problem is that document.title can ofter be quite long, and there might not be any characters diving the page title and URL, if there's URL at all. Sometimes the domain can be at the start of the title, sometimes at the end. There's no easy way to handle these titles.

varjolintu commented 1 year ago

Adding this feature to https://github.com/keepassxreboot/keepassxc-browser/issues/1888.