search

keepassxreboot / keepassxc-browser

KeePassXC Browser Extension
GNU General Public License v3.0
1.71k stars 174 forks source link

Update popup when things change immediately #76

Open rugk opened 6 years ago

rugk commented 6 years ago

Steps to Reproduce (for bugs)

E.g.:

  1. Go to a site, where you need to click "redetect login fields".

Expected Behavior

Directly after that, the popup should change.

Current Behavior

To input the password from the popup, I need to close it and reopen it. Only then the list of passwords appears there.

Just FYI: this issue is not new, it was already there with the old keepasshttp.

Possible Solution

Debug info

KeePassXC-Browser Version: 1.0.1 KeePassXC Version: 2.3.1 Operating system: Linux Browser: Firefox Proxy used: yes

varjolintu commented 6 years ago

Thanks for reporting this. It’s time to get fixed.

varjolintu commented 6 years ago

Any site you know where this happens every time?

rugk commented 6 years ago

This happens every time, independently of the site. It seems as of the update is just not implemented.

rugk commented 6 years ago

It also happens for the "reconnect" button BTW. There it should also (probably display a loading indicator, see other issue) and then directly update the pop-up.

varjolintu commented 6 years ago

This is not an easy task with the current implementation. I changed this to a wishlish item so I can do some improvements in the future.

rugk commented 6 years ago

I think this is done, is not it?

varjolintu commented 6 years ago

Nope. The popup still doesn't change dynamically if you keep it open. At least there has been no fixes to this.

varjolintu commented 1 year ago

Reminder for myself concerning this issue: Maybe the whole popup stuff could be replaced with a background script that holds and handles the popup status. In the optimal case there should be only one popup HTML and JS file, just for displaying stuff based on the current status. Anything extra could be handled in the background script(s).