keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.22k stars 1.47k forks source link

Secret Service Integration: if a prompt has exited via window decoration X, it does not re-open on subsequent calls (until keepassxc restart) #10096

Open hasezoey opened 10 months ago

hasezoey commented 10 months ago

Overview

if a prompt has been made, but cancelled via the window decorations X (close window), it does not re-open until keepassxc is restarted

this does not happen if ESC or Close (button after Unlock) is used

Steps to Reproduce

  1. start keepassxc with SSI (Secret Service Integration) and a database setup
  2. start something that asks for a prompt
  3. close that prompt via the window decorations (without unlocking)
  4. close application
  5. retry opening application to ask for a prompt
  6. observe no new prompt

Expected Behavior

window decoration X should be handled the same as ESC and Close

Actual Behavior

Prompt never shows up again if closed via window decoration X

Context

previously i though this was a vscode issue, but as it turned out from more testing around with keepassxc, it was a keepassxc issue

KeePassXC - Version 2.7.6 Revision: dd21def

Qt 5.15.11 Debugging mode is disabled.

Operating system: Manjaro Linux CPU architecture: x86_64 Kernel: linux 6.6.5-1-MANJARO Desktop Env: KDE Windowing System: Wayland

droidmonkey commented 10 months ago

What is SSI Integration? I have no idea what prompt this is referring to either.

hasezoey commented 10 months ago

What is SSI Integration?

sorry, was writing quickly and didnt check that, i meant "Secret Service Integration"

I have no idea what prompt this is referring to either.

Prompt as in the "Applications asks for X key, Allow; Deny; etc" (including the "Unlock" Prompt)

michaelk83 commented 10 months ago

Probably the close signal isn't caught, so KPXC thinks that a prompt is still open and avoids opening a new one.

droidmonkey commented 10 months ago

Yah this is likely the same problem the browser integration had with the password generator.