search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.46k stars 1.48k forks source link

System wide native messager not detected #10209

Open sertonix opened 10 months ago

sertonix commented 10 months ago

Overview

When native messaging is installed system wide (eg. in /usr/lib/mozilla/native-messaging-hosts on linux) keepassxc doesn't show it as enabled.

I can only verify this for firefox but the same problem might exist on chrome.

Steps to Reproduce

  1. enable browser integration for firefox
  2. move user native messaging config (~/.mozilla/native-messaging-hosts) to system wide native messaging config (/usr/lib/mozilla/native-messaging-hosts)
  3. check if keepassxc shows firefox integration as enabled

Expected Behavior

Keepassxc shows firefox integration as enabled

Actual Behavior

Keepassxc shows firefox integration as disabled. It works though!

Context

KeePassXC - Version 2.7.6 Revision: dd21def

Operating System: (Alpine) Linux Desktop Env: Sway WM Windowing System: Wayland

droidmonkey commented 10 months ago

That checkmark signifies the json file is deployed in the user controlled folder. It doesn't mean it's enabled or disabled. I don't recommend we make any change here. What are your thoughts @varjolintu

sertonix commented 10 months ago

Maybe a grayed out checkmark would be appropriate. Since the user can't disable it then.

varjolintu commented 10 months ago

I think there are no changes needed here. Can we actually verify the system wide settings always has the same paths in every distro? Custom Browser option is preferred if the path differs from the ones under user. Of course at this point the option does not support multiple Custom Browsers, so some manual file copying might be needed.

sertonix commented 10 months ago

Can we actually verify the system wide settings always has the same paths in every distro?

If the path is modified that is a problem of that distro not keepassxc. The current user wide config path suffers from the same issue.

varjolintu commented 10 months ago

Can we actually verify the system wide settings always has the same paths in every distro?

If the path is modified that is a problem of that distro not keepassxc. The current user wide config path suffers from the same issue.

This is one reason the Custom Browser option exists. If that option is not enought, manually copying the script file to the correct location will always work too.