Add Proton Pass importer

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.

https://keepassxc.org/

Other

21.28k stars 1.48k forks source link

Add Proton Pass importer #10465

Open scollovati opened 7 months ago

scollovati commented 7 months ago

Summary

Since Proton Pass is gaining traction, it may be great to start supporting the import of its export format: https://proton.me/support/pass-export

Context

Recently other notable importers have been added: https://github.com/keepassxreboot/keepassxc/pull/9815

droidmonkey commented 7 months ago

Ugh, why PGP encryption...

Anyway, sure we can implement that. Do they have documentation on the actual JSON format?

scollovati commented 7 months ago

Actually one can export also the unencrypted JSON. ProtonPass currently supports Credentials with TOTP, Notes, CreditCards and Passkeys (not yet released.. but will happen soon). I found a few parser implementations:

Bitwarden https://github.com/bitwarden/clients/blob/main/libs/importer/src/importers/protonpass/protonpass-json-importer.ts (sample data https://github.com/bitwarden/clients/blob/main/libs/importer/spec/test-data/protonpass-json/protonpass.json.ts)
custom script for Keepassxc CSV https://gist.github.com/nikspyratos/bd0b5ef05a4d82d2d0425cb4be9844db

I've not found an official JSON ProtonPass schema.

dinomight commented 2 months ago

I thought I might take a stab at this as I'm wanting this feature. Doesn't look too hard to implement the version without encryption and just following along with what was done for Bitwarden. I don't know how to handle the PGP encryption stuff, but I'm already up and parsing the non-encrypted export. If you have any pointers on the PGP side of things, I'm willing to go after that as well.