search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.23k stars 1.42k forks source link

Database unlock dialog does not open with Passkeys #10471

Open draekster opened 4 months ago

draekster commented 4 months ago

Overview

When logging on to websites, an unlock dialog should pop up if the database is locked. If I use passwords to log in, this works. Not for passkeys...

This makes it very unwieldy to use.

Steps to Reproduce

Example Github:

  1. create a password and a passkey for Github.
  2. lock the Keepass database.
  3. try to log in to Gihub.

Expected Behavior

If I want to log in with Passkesy, the dialog for unlocking the database should appear, as with passwords.

Actual Behavior

When logging in with the password, the dialog to unlock the database appears. Not for passkeys.

Context

KeePassXC - Version 2.7.7 Revision: 68e2dd8

Qt 5.15.11 Diagnosemodus ist deaktiviert.

Betriebssystem: Windows 11 Version 2009 CPU-Architektur: x86_64 Kernel: winnt 10.0.22621

Aktivierte Erweiterungen:

Kryptographische Bibliotheken:

varjolintu commented 4 months ago

This is a bit problematic because normally the unlock dialog request is just emitted and the actual request from extension side returns immediately. It causes the browser's own Passkeys dialog to trigger while waiting for KeePassXC to unlock. Some kind of special handling is needed for this.

droidmonkey commented 4 months ago

This should be related and fix the user verification concern as well