search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.15k stars 1.46k forks source link

"Delete Entry…" suggests confirmation dialog but doesn't show one #10543

Open ermshiperete opened 6 months ago

ermshiperete commented 6 months ago

The menu items for deleting an entry show an ellipses ("Delete Entry…") which by convention means that a confirmation dialog is shown. However, if the "Move entries to recycle bin without confirmation" option is enabled no dialog is shown. This can be unexpected and confusing to the user if he isn't aware of the state of that option.

It would be good if the ellipses would be omitted if that option is enabled.

droidmonkey commented 6 months ago

Even better, we should change the text to "Move to Recycle Bin" or similar if the recycle bin is enabled. If you have an entry selected in the bin, it would then show the Delete Entry text.