keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.61k stars 1.43k forks source link

HardwareKeyProgress Visible Even if No Hardware Key Is Found #10806

Closed 0xdeadbeer closed 3 months ago

0xdeadbeer commented 3 months ago

Overview

Hardware key progress bar is visible even if no hardware keys are found (inside DatabaseOpenWidget)

issue

The object is set to visible from inside DatabaseOpenWidget::pollHardwareKey. I wonder if this bar has a real purpose in code because grep and Qt Creator do not seem to reveal much - besides calls that simply hide or show the bar..?

question

Steps to Reproduce

  1. Open KeePassXC (with no hardware keys)
  2. Open the lock screen for any database

Context

KeePassXC - Version 2.8.0-snapshot Build Type: Snapshot Revision: da90319

Qt 5.15.13 Debugging mode is enabled.

Operating system: Arch Linux CPU architecture: x86_64 Kernel: linux 6.8.7-arch1-1

Enabled extensions:

Cryptographic libraries:

Operating System: Linux Desktop Env: XFCE Windowing System: X11

droidmonkey commented 3 months ago

It just shows that a search for a device is being made