keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.61k stars 1.43k forks source link

Various fixes to database settings #10821

Closed droidmonkey closed 2 months ago

droidmonkey commented 3 months ago

Changes are split across 3 commits intentionally.

Testing strategy

Tested extensively manually and added unit tests

Type of change

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 87.28324% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.73%. Comparing base (f80e79f) to head (245c709).

Files Patch % Lines
...i/dbsettings/DatabaseSettingsWidgetDatabaseKey.cpp 73.17% 11 Missing :warning:
src/gui/dbsettings/DatabaseSettingsDialog.cpp 77.78% 6 Missing :warning:
src/core/Database.cpp 33.33% 4 Missing :warning:
src/gui/databasekey/KeyComponentWidget.cpp 66.67% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #10821 +/- ## =========================================== + Coverage 63.71% 63.73% +0.01% =========================================== Files 365 365 Lines 44754 44775 +21 =========================================== + Hits 28515 28533 +18 - Misses 16239 16242 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

droidmonkey commented 2 months ago

Ready for another review @phoerious