search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.61k stars 1.43k forks source link

Database Report: HIBP tab only if network enabled #10822

Closed c4rlo closed 3 months ago

c4rlo commented 3 months ago

In the Database Report widget, only include the HIBP section if KeePassXC was built with networking enabled. Previously, it would show the section but it would not be functional.

Fixes #10299.

Screenshots

I can supply if interested.

Testing strategy

I have manually confirmed that no HIBP section shows up in the Database Report when building with -DWITH_XC_NETWORKING=OFF. When built with networking enabled, it shows up as normal.

Type of change

droidmonkey commented 3 months ago

Actually, after the debacle with debian recently, we are likely going to include more messages about features being unavailable because they weren't compiled in. As a result, we won't be merging this request.

You can change the behavior to just show a warning about network access being disabled (which I think it already does).

c4rlo commented 3 months ago

Hah, I guess you're referring to https://fosstodon.org/@keepassxc/112417353193348720 and https://www.theregister.com/2024/05/22/apt_gains_keepassxc_loses/ etc. Fair point. I can change it to have a message saying this feature is disabled in the build.

c4rlo commented 3 months ago

You can change the behavior to just show a warning about network access being disabled (which I think it already does).

You're right, it already does that. It shows "This build of KeePassXC does not have network functions. Networking is required to check your passwords against Have I Been Pwned databases." That sounds like exactly the desired behaviour then.

Closing this.

droidmonkey commented 3 months ago

Thank you