search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.07k stars 1.42k forks source link

Passkeys: Fix incorrect username fill #10874

Closed varjolintu closed 3 weeks ago

varjolintu commented 4 weeks ago

Fix filling wrong username with a normal entry that has a passkey. There are two possible situations with entries that has a passkey: 1) Entry only has a passkey. Username is set to KPEX_PASSKEY_USERNAME. 2) Entry has normal credentials and KPEX_PASSKEY_USERNAME.

In the second situation the normal username needs to be returned if entry has a passkey but KPEX_PASSKEY_USERNAME differs. The KPEX_PASSKEY_USERNAME attribute will be still used during authentication normally. The username only matters how the credential is displayed in the extension side, and during the Access Confirm Dialog.

Fixes #10840.

Testing strategy

Manually.

Type of change

varjolintu commented 4 weeks ago

Some changes needed for this.

EDIT: Should be fixed. Please verify. There was a bug with entries without any passkeys. The username could be returned as empty.