search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.94k stars 1.45k forks source link

Search entry: respect shortcut config on Copy key #10882

Closed c4rlo closed 3 months ago

c4rlo commented 3 months ago

If the system Copy key sequence (i.e. Ctrl+C or Cmd+C) is pressed while inside the search entry without any text being selected, previously we would copy the currently selected entry's password. This made sense when keyboard shortcuts were fixed. Now that they are configurable, change it to re-route the event to the main window, which can then take the appropriate action (i.e. Ctrl+C might be bound to some other action).

I originally had this as part of #10853, but decided it makes more sense as its own PR.

Testing strategy

Confirmed that existing tests cover this case (and tweaked them a tiny bit).

Type of change

c4rlo commented 3 months ago

CodeQL failure seems to be a GitHub issue:

GitHub Actions has encountered an internal error when running your job.