search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.07k stars 1.42k forks source link

Require Qt >= 5.12 #10900

Closed c4rlo closed 2 weeks ago

c4rlo commented 3 weeks ago

Bump the minimum required Qt version up to 5.12, as per https://github.com/keepassxreboot/keepassxc/issues/10859#issuecomment-2148477826. Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work (and at some point, INSTALL.md stated that 5.9.5 was the minimum).

With this, we are able to remove a whole bunch of #ifdef'd code.

Testing strategy

All tests continue to pass, except for:

QFATAL : TestGui::testRemoteSyncDatabaseRequiresPassword() Received signal 11
         Function time: 658ms Total time: 5010ms
FAIL!  : TestGui::testRemoteSyncDatabaseRequiresPassword() Received a fatal error.
   Loc: [Unknown file(0)]

However, this also happens on the develop branch.

Type of change

c4rlo commented 3 weeks ago

Ubuntu test failure seems unrelated:

19:02:41   FAIL!  : TestCli::testClip() '(isTotp(clipboard->text()))' returned FALSE. ()
19:02:41      Loc: [/opt/buildagent/work/c401303cba1b4098/tests/TestCli.cpp(680)]