search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.94k stars 1.45k forks source link

Use secure temp directory for remote sync (#10911) #10914

Open t-h-e opened 3 months ago

t-h-e commented 3 months ago

Fixes https://github.com/keepassxreboot/keepassxc/issues/10911

Screenshots

Testing strategy

Type of change

t-h-e commented 3 months ago

@hifi can you have a look at this?

droidmonkey commented 3 months ago

Regarding the inability to call upload as a standalone thing, RemoteParams could include the "target" file path for using upload or download functions, if set the m_temporaryFileLocation variable is ignored. Another option is to just reintroduce the filepath variable to upload, but as an optional second parameter.

t-h-e commented 3 months ago

Regarding the inability to call upload as a standalone thing, RemoteParams could include the "target" file path for using upload or download functions, if set the m_temporaryFileLocation variable is ignored. Another option is to just reintroduce the filepath variable to upload, but as an optional second parameter.

I think it is fine as is as we currently have no standalone upload. In case, we want to add an upload only functionality, this is definitely the way to go.