keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.03k stars 1.42k forks source link

Passkey importer: fix file picker parent #10951

Closed c4rlo closed 1 week ago

c4rlo commented 1 week ago

When selecting Database → Import Passkey, we show a file picker. Previously, we did not specify a parent widget for it. This could have undesirable effects on its presentation. (For example, with the Sway tiling Wayland compositor, it would show the file picker as a tiled window rather than a floating one.)

Fix the issue by passing in the parent widget. This is also in line with all other usages of FileDialog::getOpenFileName() in this project.

Testing strategy

I have confirmed that this change fixes the issue for me, using Sway.

Type of change