search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.01k stars 1.42k forks source link

KeePassXC Installer should check VCredist Version #10974

Open dvschuetz opened 1 week ago

dvschuetz commented 1 week ago

Summary

On installing, the KeePassXC installer should check, whether the Visual C++ redistributable library is actual enough for the current KeePassXC version.

Actual Behaviour

The KeePassXC Installer checks, whether VC redist x64 is installed or not. (If not, ... I don't remember whether it just gives a message or leads to download VCredist.x64.) But if an older VCredist.x64 version is present, e.g. version 14.32.31326 of 2023, KeePassXC 2.7.9 will install, but not start and crash silently.

Examples

Bug #10925 Bug #10973

Context

Any computers with Windows 10 or 11 which installed KeePassXC the first time more than a year ago

droidmonkey commented 1 week ago

Yes, can add but vcredist are supposed to be backwards compatible... this is ultimately a Microsoft bug

droidmonkey commented 1 week ago

FWIW, a minimum version detection wound not have prevented or alerted people to this. For all we knew we were fully compatible with all versions of the msvc redist. Microsoft made no mention of an incompatibility and we didn't use any new api's between releases.