keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.01k stars 1.42k forks source link

Add a password discard confirmation #10994

Open Jookia opened 4 days ago

Jookia commented 4 days ago

This PR adds a confirmation dialog on password generator close that confirms discarding the password. Fixes #10831 .

Screenshots

A dialog with a warning sign titled "Confirm Close Password Generator." It asks "Discard this password forever?" and lists two options: Discard and No

Testing strategy

Tests are currently broken: Something about MessageBox::setNextAnswer is blocking the closing of the database in the test. Once this is fixed (I need help with this please) I will write tests that check:

Type of change