michaelk83
commented
3 days ago Why is KeeShare considered basic? It would argue that it's an advanced niche feature. It's not needed for most single-user use, and it requires network access.
I would also argue that Secret Service is rather basic for Linux users, as it's the main method for client applications to store and retrieve their credentials. Though I agree that it's less basic than Auto-Type and Yubikey support. And I agree that it can be grouped with SSH Agent and Browser integration, since they all add an IPC layer.
I would group these features like so:
- Basic (no IPC and no networking): core functionality, Yubikey, Auto-Type.
- Local IPC, no networking: above + Browser (and passkeys), SSH Agent, Secret Service.
- Full: above + networking: Update Checks, Key Share, remote DB, icon download, HIBP.
(Technically, browser integration is also rather useless without network access, but as I understand the network access isn't done by KPXC itself.)
varjolintu
droidmonkey
codecov[bot]
KPXC_MINIMALflag that removes advanced features from the build. Basic features are no longer guarded by feature flags.This change also cleans up the main CMakeLists.txt by re-arranging some content and placing macros into a dedicated include file. The minimum CMake version was bumped to 3.16.0 to conform to our minimum Ubuntu support of Focal (20.04). This also allows us to default to C++20, we fall back to C++17 for Qt versions less than 5.15.0 due to lack of support.
Lastly this change removes the KEEPASSXC_BUILD_TYPE="PreRelease" which is never used. We only support "Snapshot" and "Release" now.
Testing strategy
Tested locally and with existing CI
Type of change