search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.36k stars 1.47k forks source link

Command for 'Hide Passwords' not working on the preview panel! #11287

Closed Dominiquini closed 1 month ago

Dominiquini commented 1 month ago

Overview

The command (or screenshot Ctrl+Shift+C) for unhide passwords is not working right on the preview panel! While I'm able to unhide passwordss on the main window (password column), in the preview panel I need to click on the yey button to unhide.

Steps to Reproduce

  1. Open a database
  2. Select a entry
  3. Visualize the preview
  4. Unhide all passwords (Uncheck View -> Hide Passwords)
  5. The password on the preview windows remains hidden

Expected Behavior

The passwrod's field need to be showing by default, like the username field!

Actual Behavior

I need to manually unhide the password field on the preview window!

Context

The logic for the password's field and username's field should be equal; on the main window or on the preview window! I was able to change this behavious on the (Security Settings -> Hide passwords in the entry preview panel), but either way, the behaviour is different for the username and the password! I think that both fields should have the same behaviour, even if this settings should be removed!

App Info

KeePassXC - Version 2.7.9 Revision: 8f6dd13

Qt 5.15.15 Debugging mode is disabled.

Operating system: CachyOS CPU architecture: x86_64 Kernel: linux 6.10.5-1-cachyos

Enabled extensions:

Cryptographic libraries:

Operating System: Linux (Cachy OS) Desktop Env: KDE Windowing System: X11

droidmonkey commented 1 month ago

Application Settings -> Security tab -> Hide passwords in the entry preview panel

Dominiquini commented 1 month ago

Application Settings -> Security tab -> Hide passwords in the entry preview panel

I know that option! I indicate that... The problem is if I uncheck the 'Hide passwords in the entry preview panel' on the security tab, the password on the preview panel is visible, even when I select 'Hide Passwords Ctrl+Shift+C' on the view menu! I think the password should behave like the username both on the main window or the preview panel and the option on the security panel should be removed! Of course this is just a suggestion. Feel free to disregard... Thanks.

droidmonkey commented 1 month ago

It is slightly confusing. The view menu option is meant for the entry list only (it used to be accessed from right-clicking the entry list header). We do want two separate settings though as I suspect most people want the entry list to hide passwords while showing the current select entry's password only.

Dominiquini commented 1 month ago

It is slightly confusing. The view menu option is meant for the entry list only (it used to be accessed from right-clicking the entry list header). We do want two separate settings though as I suspect most people want the entry list to hide passwords while showing the current select entry's password only.

Is that the 'Hide Usernames Ctrl+Shift+B' option, under the 'View' menu toggle the visibility of the usernames from the entry list and the preview panel. I just think the two options should behave similarly!

Thanks.