search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.92k stars 1.44k forks source link

Add wl-clipboard to Flatpak #11292

Open DPTJKKVH opened 1 week ago

DPTJKKVH commented 1 week ago

Overview

When copying a password with CTRL + C the password is only cleared after the countdown if the KeepassXC window is in focus. If it is out of focus, the password remains in the clipboard indefinitely.

Steps to Reproduce

  1. Click on a database entry.
  2. CTRL + C to copy the password
  3. Highlight a different window than the KeepassXC window. (e.g. a text editor)
  4. Wait until the "clear clipboard after" timer runs out.
  5. CTRL + V in the different window.

Expected Behavior

No password should be pasted since it should have been cleared form the clipboard after the timer ran out.

Actual Behavior

The password can still be pasted.

Context

Here is a video of the bug. keepassxc_bug.webm

KeePassXC - Version 2.7.8 Revision: f6757d3 Distribution: Snap Qt 5.15.11 Operating System: Ubuntu 22.04.5 LTS Desktop Env: Gnome 42.9 Windowing System: Wayland

droidmonkey commented 1 week ago

This was fixed in 2.7.9

DPTJKKVH commented 1 week ago

@droidmonkey

Please reopen this issue. I tried it with the 2.7.9 Flatpak version and the issue still persists. Video below! KeePassXC - Version 2.7.9 Revision: 8f6dd13 Distribution: Flatpak Qt 5.15.10

Video keepassxcbugwithflatpak.webm

droidmonkey commented 1 week ago

This isn't our bug. It's a bug/feature of GNOME on Wayland. We try to work around it by calling wlcopy directly instead of through Qt. Unfortunately we can't do that with Flatpak.

DPTJKKVH commented 1 week ago

Understood. Why is the Snap version still on 2.7.8 on the stable branch though? Is that deliberate?

droidmonkey commented 1 week ago

The snap owners have our update held up in some manual review. The whole process with snaps is broken.

DPTJKKVH commented 1 week ago

Thank you for answering my questions and maintaining this project despite the many challenges it poses. Fully understood and I will move on to the PPA then.

droidmonkey commented 1 week ago

@DPTJKKVH you may have to install wl-clipboard if you haven't already even with the ppa.

DPTJKKVH commented 6 days ago

@droidmonkey

fyi: I didn't need to install wl-clipboard for the clipboard clearing to work as intended. (I verified in synaptic that it isn't installed.) Just in case that information is useful.

droidmonkey commented 6 days ago

I'm going to try to add wl-clipboard to the flatpak itself, see if that works