keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.43k stars 1.48k forks source link

Unable to fetch MS Edge browser's favicon #11322

Closed pa-0 closed 1 month ago

pa-0 commented 1 month ago

Overview

Cannot download the favicon for Microsoft Edge.

Steps to Reproduce

  1. Paste 'https://edgestatic.azureedge.net/welcome/static/favicon.png' into the favicon URL field
  2. Click Download favicon
  3. Error: Unable to fetch favicon

Expected Behavior

The Edge favicon is downloaded and added to the library.

Actual Behavior

KeepassXC returns an error

Context

KeePassXC - Version 2.7.9
Revision: 8f6dd13

Qt 5.15.11
Debugging mode is disabled.

Operating system: Windows 11 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.22631

Enabled extensions:
- Auto-Type
- Browser Integration
- Passkeys
- SSH Agent
- KeeShare
- YubiKey
- Quick Unlock

Cryptographic libraries:
- Botan 3.1.1

Operating System: Win 11 Enterprise

droidmonkey commented 1 month ago

Icon doesn't exist: https://edgestatic.azureedge.net/favicon.png

We pull from the base domain not from a link to an image.

For your case, you can simply download the icon in your browser then import it into keepassxc from the icons selection screen.

pa-0 commented 1 month ago

Ahh, I swear it was here yesterday. Thanks sorry for wasting your time.

pa-0 commented 1 month ago

Actually the link you posted is not the same as the link I posted.

https://edgestatic.azureedge.net/welcome/static/favicon.png

droidmonkey commented 1 month ago

we don't care what the path of the link is. We don't pull an image, we check the base domain