search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.39k stars 1.48k forks source link

Preview panel adds extra space to translate “invalid key” #11357

Open xboxones1 opened 1 month ago

xboxones1 commented 1 month ago

Overview

1 For some languages, an extra space is added to the translated word “invalid” in the preview panel for TOTP. I checked the translation files and there are no problems, everything is correct.

Steps to Reproduce

  1. Configure TOTP with an invalid key
  2. For example, switch to Bulgarian language
  3. Show TOTP in the preview panel
droidmonkey commented 1 month ago

Good find, we should be handling totp generation better. Right now, if there is an error, either the string "Invalid Settings" or "Invalid Key" is returned instead of a totp value or a blank string. We should handle that situation more gracefully and in the context of the data handling.