search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.39k stars 1.48k forks source link

Search shortcut (ctrl+f) doesn't work on keyboard layout different from English #11382

Closed lansman closed 1 month ago

lansman commented 1 month ago

Overview

Search shortcut (ctrl+f) doesn't work on keyboard layout different from English

Steps to Reproduce

  1. Open KeePassXC Window
  2. Switch your keyboard to some layout different from EN (RU for example)
  3. Press ctrl+f (cmd+f on mac)

Expected Behavior

Focus should switch to the Search field above, as it happens on EN layout

Actual Behavior

Focus doesn't switch, it remains wherever it was

BTW

Other shortcuts (copy username ctrl+b, copy password ctrl+c) work fine

KeePassXC - VERSION 2.7.9

Operating System: macOS

droidmonkey commented 1 month ago

We use Qt's definition for the "find" shortcut which may be platform and language specific. 2.8.0 will let you remap keys so this is already completed from development perspective.

https://github.com/keepassxreboot/keepassxc/blob/95bae8377c88f46fda565e09fee25d7ba684fe9e/src/gui/MainWindow.cpp#L115

lansman commented 1 month ago

@droidmonkey cmd+f works in both layouts in all programs on my Mac without issue. For example, QBittorrent is written on QT too and both layouts work just fine.

Could you add a second layout on your pc and test it?

droidmonkey commented 1 month ago

You can also press F3 to focus search. I'm not disputing it's broken, just that we already implemented a fix/workaround.

lansman commented 1 month ago

I've downloaded a KeepassXC for Windows, and both shortcuts work fine there. There is some mac-specific problem here.

F3 works, thank you for workaround.

I hope remap feature will allow adding another shortcut for search without breaking existing EN one.

droidmonkey commented 1 month ago

It's likely a qt bug in that case