Accept both upper and lowercase 'S' for custom attribute for more compatibility

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.

https://keepassxc.org/

Other

21.39k stars 1.48k forks source link

Accept both upper and lowercase 'S' for custom attribute for more compatibility #11420

Open bigjim80 opened 3 weeks ago

bigjim80 commented 3 weeks ago

I had an issue that auto type didn't work when using a kdbx from Keepass2.

Other KeePass forks both accept {S:Attr1} and {s:Attr1} as a placeholder for custom attributes. Keepassxc only accepts an uppercase S.

I don't see any risk by accepting both {S: and {s: as placeholder, which will further improve cross compatibility.

droidmonkey commented 3 weeks ago

Why just this placeholder? If we are going to ignore case, then we do it for everything. Looks like we do that for the huge list below already. Ref is the only stand out now.

bigjim80 commented 3 weeks ago

You are right, I thought it would be too much, but it makes more sense to be consistent. I'll see when I have some time to implement it in this PR and add some tests.