keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.39k stars 1.48k forks source link

Replace legacy code on macOS builds #11428

Closed FischLu closed 1 week ago

FischLu commented 2 weeks ago

fix #11288, The CGDisplayStreamCreate function has been deprecated and the current code fails to compile on macOS 15 and above. Following Apple's official recommendations, this fix replaces CGDisplayStreamCreate with ScreenCaptureKit (MacOS 12.3+). Since ScreenCaptureKit is an asynchronous framework, necessary semaphore waiting has been added to the code. This change successfully triggers the screen recording permission request dialog and allows proper use of autotype when permission is granted. The code has been tested and confirmed working on macOS 15.0.1.

Type of change

droidmonkey commented 2 weeks ago

Omg thank you, I really didn't want to figure this one out.

FischLu commented 2 weeks ago

After adding Q_UNUSED(error), the automated tests do not pass. You may check the reason.

droidmonkey commented 2 weeks ago

The failures are ephermal and unrelated

TheRojam commented 1 week ago

Thank you guys!