Minor style fixes - Githubissues

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.

https://keepassxc.org/

Other

21.39k stars 1.48k forks source link

Minor style fixes #11445

Open xboxones1 opened 2 weeks ago

xboxones1 commented 2 weeks ago

Clean up removed elements
Removed widgets for which you don't need to change the color
Fix scrollbar groove color when disabled

Screenshot

Before. This is what it looks like if we don't change the color for DatabaseWidget #groupView, DatabaseWidget #tagView when they are disabled. Without fixing the scrollbar. before After. With the scrollbar fix after

Testing strategy

Manually

Type of change

✅ Bug fix (non-breaking change that fixes an issue)

xboxones1 commented 2 weeks ago

Or leave it the way it is now? This is how it looks when we change the color for DatabaseWidget #groupView, DatabaseWidget #tagView when they are disabled. Style customization in QT is complicated.

382577698-3e4a82de-3137-4224-84c2-4276678f5f18

droidmonkey commented 2 weeks ago

I like the After on your initial post the best, so your proposed change should be applied.