search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.39k stars 1.48k forks source link

Detect outdated VC Redist with MSI Installer #11469

Open droidmonkey opened 1 week ago

droidmonkey commented 1 week ago

image

This change will prevent installation of KeePassXC until the VC Redist is updated. Unfortunately, we cannot launch the web browser since you are only allowed to define one launch command and we use that to start KeePassXC post-install.

Testing strategy

Tested by reducing the version number in the registry.

Type of change

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.85%. Comparing base (2fc24be) to head (b6c6ae5). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #11469 +/- ## =========================================== + Coverage 63.84% 63.85% +0.01% =========================================== Files 362 362 Lines 38115 38115 =========================================== + Hits 24334 24336 +2 + Misses 13781 13779 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phoerious commented 5 days ago

Can you make it a clickable link?

droidmonkey commented 5 days ago

No, unfortunately not

phoerious commented 5 days ago

At this point we should probably localise the installer, though. I bet many non-English users will have (even more) trouble with this message.