search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.4k stars 1.48k forks source link

TouchID using deprecated API #2484

Open droidmonkey opened 6 years ago

droidmonkey commented 6 years ago 
/Users/droidmonkey/keepassxc/src/touchid/TouchID.mm:101:69: warning: 'kSecAccessControlTouchIDCurrentSet' is
      deprecated: first deprecated in macOS 10.13.4 [-Wdeprecated-declarations]
                                                                    kSecAccessControlTouchIDCurrentSet, // dep...
                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                    kSecAccessControlBiometryCurrentSet
/System/Library/Frameworks/Security.framework/Headers/SecAccessControl.h:92:5: note:
      'kSecAccessControlTouchIDCurrentSet' has been explicitly marked deprecated here
    kSecAccessControlTouchIDCurrentSet      API_DEPRECATED_WITH_REPLACEMENT("kSecAccessControlBiometryCurrentS...
    ^

Looks like the new API is called kSecAccessControlBiometryCurrentSet.

yan12125 commented 6 years ago

According to Apple, kSecAccessControlBiometryCurrentSet requires macOS 10.13. Will switching to the new API bring compatibility issues?

droidmonkey commented 6 years ago

More than likely yes, this is just to document that we are using a deprecated API, no action is required at this time.

yan12125 commented 6 years ago

Thanks! It's a great to hear that 10.12 is not going to be abandoned in 2.4.0.

phoerious commented 5 years ago

We will be having problems with binary compatibility, however. We cannot build with support for Mojave + modern Qt and have it running on older macOS versions, although our code would support it.