search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.27k stars 1.47k forks source link

Disable "Perform Autotype" button by default. #2665

Closed Bretzky closed 3 years ago

Bretzky commented 5 years ago

I just hit this button by accident, not even aware it existed, and it posted my email & password in irc.

droidmonkey commented 5 years ago

The button is still there in 2.4.0, but we changed the shortcut to CTRL+SHIFT+V to prevent accidentally activating it.

Germano0 commented 5 years ago

Please @phoerious @TheZ3ro @droidmonkey do add an option to completely disable auto type. You don't have idea how many times I runned it by mistake either by pressing the wrong keyboard combo or clicking the wrong entry. It's definitely a "time bomb" Moreover the "confirm before auto type" does not work https://github.com/keepassxreboot/keepassxc/issues/579

ddombrowsky commented 5 years ago

:+1: +1 This can be disabled per-entry, but cannot be disabled globally, afaik. This is a bug. I've had to change multiple passwords because C-v is right next to C-b.

ddombrowsky commented 5 years ago

changing the global shortcut key doesn't seem to do anything either :/

droidmonkey commented 5 years ago

If you don't want to use autotype at all you can delete the "default autotype sequence" in the root group to effectively disable the CTRL+V action. It will still switch windows, but nothing will type.

image

You could enable autotype on a per-entry basis by defining a sequence for that entry. Or you can do it for a group by disabling inherit from parent.

ddombrowsky commented 5 years ago

That would be an acceptable workaround, except it doesn't seem to work. Changing it to blank will reset it back to "use default." I can change it to a "space" however, which I will do now.

This is in 2.3.1, the version installed in ubuntu 18.04's packages.

droidmonkey commented 5 years ago

Good to know!

ochilan commented 5 years ago

What happens if you set "Auto-Type" to "Disable" instead of "Inherit from parent group" in the Root group (instead of modifying the Auto-Type sequence)? The corresponding drop-down menu is also visible in the screenshot previously posted by droidmonkey. Once I set this option to Disable, Auto-Type doesn't seem to do anything anymore, as I would expect. I agree though that this option is hidden pretty well.

wolframroesler commented 5 years ago

Considering that some people (including myself ;-) ) would like the old Ctrl-V auto-type back (#3018, #3051) or at least want the hotkey to be configurable (#2689, #3017), how about a new setting "Auto-type hotkey" with three options "Shift-Ctrl-V (recommended)", "Ctrl-V (not recommended)", and "None"?

phoerious commented 5 years ago

I think this issue is non-negotiable. There has been a handful of vocal people wanting the old hotkey back, but the vast majority has just moved on. If we implement customizable hotkeys one day, this might be included, but we will not implement hotkey customizations because of this.

arcticoder commented 3 years ago

You understand that control-shift-V is also the shortcut key used in Office for pasting unformatted text. That muscle-memory isn't going away for me anytime soon, and I'm pasting into keepassxc all the time. So this is not a worthwhile risk to take for me, I have to uninstall this program until it's resolved.

droidmonkey commented 3 years ago

This was obviated by the 2.7.0 Auto-Type overhaul. A warning is shown before performing entry level Auto-Type.

rpgdev commented 2 years ago

@droidmonkey now I'm in need of disabling this warning. Where can I disable it? It gets in the way of EVERYONE who actually wants to use the autotype hotkey.