View all SSH keys or all entries with SSH keys

outdooracorn commented 5 years ago

Summary

At the moment it takes a while to add/remove SSH keys to/from the ssh-agent as you have to go to the SSH Agent tab of each entry. Having a way to view all the SSH keys or all the entries with SSH keys would speed up adding/removing all or specific SSH keys.

Desired Behavior

Show all SSH keys or all entries with SSH keys
Add/remove all SSH keys
Add/remove a selection of SSH keys

Possible Solutions

In no particular order but numbered so can be referenced:

To implement showing all keys/entries with keys:

Click on an icon to display a popup of all the SSH keys. This would be similar to how the KeeAgent plugin of KeePass2 does it. Screenshot:
Click an icon to display all the entries that have SSH keys. Could utilise the same view when searching for entries. This could also work with special search parameter like "HAS_SSH_KEY:TRUE".
If tags (#508) were implemented you could tag all the entries with SSH keys and then search on that tag. Would also be able to tag and search for a specific category of keys (e.g. work, personal, client-abc etc.).

As I currently see it:

Advantages of solution 1. is you get to see useful info about the actual keys such as comment, size, type and fingerprint without clicking into the entry. Disadvantage is you might not be able edit the entry/SSH key from this view.
Advantages of solution 2/3. is it utilizes the same view as for searching (so familiar to users and I assume easier to develop) and can then click into an entry to edit. Disadvantage is that you have to click into the entry to view any info about the SSH key (which is what you are searching for).

To implement adding all/selected keys to the ssh-agent:

Once #1815 is implemented. Highlight keys/entries that want to be added/removed from the ssh-agent. Right click Add/Remove key to SSH agent OR Ctrl+H shortcut.

droidmonkey commented 5 years ago

I like this, it should be a part of the database settings (and the future database info) view.

hifi commented 4 years ago

The suggestion to simplify this into a search filter that shows only entries that has a key configured would be the fastest to implement. With #4290 merged managing keys from the entry list is easy.

You can, however, already do this manually by using a unique search string and add that into every entry (like "ssh") and with #4290 it works pretty much like that then.

outdooracorn commented 4 years ago

I think that would be an acceptable solution. I've not tested out #4290 but the screenshot looks good, thanks 👍

keepassxreboot / keepassxc