search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.16k stars 1.46k forks source link

Add the ability to change accent color #5335

Open DanyGee opened 4 years ago

DanyGee commented 4 years ago

Summary

Allow selection of an accent color, so users can change the default green to color of their choice (either a full spectrum color chooser or some preinstalled few ones should do).

Examples

keepassxc_accent_blue

keepassxc_accent_violet

Color picker might look like this: color_picker1

Eventually like this: color_picker2

Context

The context is purely aesthetic. User might want to match the apps accent with his desktop theme or match the colors of his company he owns or works in. As minor as it may seem, it will still be value added 💡

droidmonkey commented 4 years ago

Not a bad idea, but will require a fair amount of work to get the shading and such correct.

pkrc267 commented 4 years ago

I would like to work on it. Have basic understanding of Qt framework. Will be a good learning experience.

droidmonkey commented 4 years ago

Good luck!

pkrc267 commented 4 years ago

Need a little help. I have gone through CONTRIBUTING.md, forked and cloned the repository. How can I open the project in Qt creator?

droidmonkey commented 4 years ago

Open the cmakelists.txt

pkrc267 commented 4 years ago

So I have been a bit occupied with my college curriculum. But I'm back and here is a little progress that I've made. I'm aware of a few points like position of the Color button, but that I think can be changed with some help. For now how does this look. Also please tell me what can/should be done.

p.s. I added the gradient as it looked cool. But have to work on text color change accordingly.

Clear video: https://drive.google.com/file/d/1IdX9SJIJo0vZCIEhYLYHpYpJeqPhXbYC/view?usp=sharing

GIF: ezgif com-video-to-gif

Screenshot:

droidmonkey commented 4 years ago

Its an experiment, but that would never be merged in unfortunately. Keep learning, you're making progress.

watchpocket commented 2 years ago

Adding this feature isn't just an esthetic thing.

In a list of 40 or 50 entries, all of which may have different background colors, that green highlight color does not stand out enough to show you, at a glance, where you are.

It doesn't show you well enough which entry you're on (unless you look really hard and click around on a few other entries to see where that green moves to).

(I can't tell if what pkrc267 is working on is what I'm talking about. I just need to create an entry-background highlight color that allows me to distinguish it from all the other entry-background colors. If I could make that green a bright red, for example, it would be a BIG user-interface help. (since I don't use bright red for the background of any other entry.)

In almost every other respect, KeePassXC is a fantastic app.

So when you say, @droidmonkey, that this feature will "never be merged," are you saying that the ability to change the entry-highlight color is never going to be added to program?

AlexDeFoc commented 2 years ago

I have an idea. I woukd be a good start to have the accent color of the apps listed somehow in a file. And you can edit it. (if it doesnt have the ability to inject other malware or other things thorund the file, when the app reading the files, huh)

MathieuDR commented 9 months ago

I think theming in general could use an overhaul. Eg setting up your own colour schemes to use something like catppuccin would be amazing :)

pkrc267 commented 6 months ago

I had stopped working on this long back due to my limited sense of design skills and this being experimental feature. But it was fun though. If anyone would like to take up and work on a revamp, it would be nice. If it is aesthetic enough to attract attention it might get merged. You never know.