search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.43k stars 1.48k forks source link

Allow KeeShare databases with any extension #7241

Open jversusk opened 2 years ago

jversusk commented 2 years ago

I prefer to save databases with a different extension, so it's not easily identifiable as a KeePass database. While KeePassXC allows opening and saving of databases with any extension, the KeeShare (Synchronize) feature insists on a .kdbx extension. This is an unnecessary requirement and inconsistent with the open/save behavior.

Steps to Reproduce

  1. With a database opened and Import/Export enabled in app settings, open the edit sheet on a group
  2. Try to set up KeeShare Synchronize with Path of a file having a generic extension like .txt

Expected Behavior

The Path file extension shouldn't matter as long as the container is of the correct type.

Actual Behavior

The following error appears:

Your KeePassXC version does not support sharing this container type. Supported extensions are: kdbx.

Context

I suggest making the KeeShare behavior consistent with the open/save behavior, by removing the .kdbx extension requirement.

Environment

KeePassXC - 2.4.3 Operating System: Linux

droidmonkey commented 2 years ago

You aren't hiding anything by having a different extension for your database. How do you think we detect it is a kdbx database without the extension being correct? There are two "magic" numbers at the start of the file that identify it. Any program can use those to find the databases in your files 😉

I do agree we will remove the extension check for keeshare eventually.

jversusk commented 2 years ago

The idea isn't to hide it from programs, but to not make it obvious to a person 😁