Update macdeployqt to use cpack pre build script

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.

https://keepassxc.org/

Other

21.33k stars 1.47k forks source link

Update macdeployqt to use cpack pre build script #7924

Open droidmonkey opened 2 years ago

droidmonkey commented 2 years ago

Hi, came across your code when trying to figure out how to use macdeployqt. Your code got me on the right track, but I found that it is possible to use CPACK_PRE_BUILD_SCRIPTS to do this. The CMake code becomes a bit cleaner in that case. You can see here how we did it:

https://github.com/inviwo/inviwo/pull/1283/files#diff-6febc3dfa67fbc0019888cf7603b427537d89f727885f39ce7fad7b0e2c910f6

ResearchDaniel commented 2 years ago

Can also add that I did not need to provide extra binaries for the packaging to work as macdeployqt changed the RPATH for them anyway. Not sure if that is still needed in your case.