keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.72k stars 1.43k forks source link

Keeshare feature with automatic save #8101

Open JD-aus opened 2 years ago

JD-aus commented 2 years ago

Hi All,

Overview

I have setup keeshare files on a mapped network drive 2 computers able to access these files without issue. The Keeshare feature is fantastic for sharing certain groups with certain users. We like the keeshare feature as it is a file that forms part of each users personal keepass database and not a seperate file that needs to be loaded (which is painful on apple mobile phones).

We want to ensure that each user has automatic save turned on and that auto reload is also enabled to get the latest updates as they occur, however these features cannot be used together with keepass using the shared files method i have highlighted below.

Settings to Reproduce

In "Settings > General > File Management", enable the following features:

Steps to Reproduce

  1. Save a keeshare file onto a network share that is accessible from 2 or more computers (computer1 & computer2)
  2. From computer1 when adding / editing an entry in a shared group, the automatic save feature will save the keeshare file as well as the database, which is great.
  3. From computer2, the auto reload feature detects the updated file and reloads the keeshare file, which for some reason causes an automatic save to occur on computer2, which saves the keeshare file and database.
  4. On computer1, the auto reload feature detects the updated file and reloads the keeshare file, which should have no changes since it was altered on this computer, which for some reason causes an automatic save to occur on computer1
  5. Steps 3 & 4 repeat in an endless update loop until one of the applications is either closed, keeshare set to read only or the settings changed.

Expected Behavior

at step 4, if no changes have occured within the keeshare file since last read/save, no save is required.

Workaround (of sorts)

By disabling either the automatic save or auto reload feature in settings, the fault does not occur, however it would be great to see this resolved as no other password system i have seen allows for this level of flexibility for sharing passwords between users on different systems with different mobile devices and personal other than https://github.com/Angelelz/KeePassMasterSlaveSync for the original keepass, which appears to be no longer actively supported.

KeePassXC - Version 2.7.1 Revision: 5916a8f

Qt 5.15.3 Debugging mode is disabled.

Operating system: Windows 10 Version 2009 CPU architecture: x86_64 Kernel: winnt 10.0.19044

Enabled extensions:

Cryptographic libraries:

droidmonkey commented 2 years ago

Keeshare is being completely rewritten for 2.8.0 and those rewrites will also specifically target this problem.

zsmbrvr commented 2 years ago

I'm just confirming the same behaviour. When is 2.8.0 expected?

DarrenSchwartz commented 1 year ago

I'm really looking forward to a fix for this.

zsmbrvr commented 1 month ago

Keeshare is being completely rewritten for 2.8.0 and those rewrites will also specifically target this problem.

Now that 2.8.0 is just around the corner, do you think this will be fixed?