search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.96k stars 1.45k forks source link

Feedback for icon download doesn't show when using DDG #8266

Open Elaborendum opened 2 years ago

Elaborendum commented 2 years ago

Summary

When editing an entry and directly downloading a favicon from there, it's currently not possible to easily know if the download was successful or what favicon was downloaded.

There should be some message that indicates the state of the download (successful or failed) and a preview of the current icon that, on click, could direct you to the proper "Icons" section.

Examples

Keepass2 has the icon currently being used right in the main edit section. imagen

The message that notifies the user about the state of the download of the icon could be similar to the message that notifies the user if the database couldn't be saved, a bright message at the top.

Context

This is mainly of help when adding an entry for the first time. Specially when the download failed and the user can't realize until after saving it..

droidmonkey commented 2 years ago

We display a banner at the top that indicates the icon download success or failure.

Elaborendum commented 2 years ago

Nothing appears for me when downloading icons using the DDG service, only when downloading icons directly. I'm on 2.7.1, should I open an issue or this intended?

droidmonkey commented 2 years ago

Can confirm this is a bug, when downloading a new icon from DDG, no message is shown. I'll just reuse this report.