keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.34k stars 1.47k forks source link

Auto-type doesn't work in a modal using * or empty window titles #8570

Open murder opened 2 years ago

murder commented 2 years ago

Overview

KeepassXC does not interact with window that doesn't contain a title even when using the wildcard * In my case this was noted when I was going to login to a Remote Desktop Session, msrdcw.exe invoked

Steps to Reproduce

  1. Create an entry -> Auto-Type -> [x] Enable Auto-Type -> Hit the + button to create a Window Association -> Input the wildcard character * in Window Title and hit OK
  2. Open the Remote Desktop client - my current version is 1.2.3577.0 (x64)
  3. Register to a workspace or connect to a Windows Virtual Desktop (Azure)
  4. A new modal window will show up for Microsoft accounts that has the executable named as Microsoft.AAD.BrokerPlugin.exe and is responsible for the authentication between the client and server
  5. Try using your hotkey

[AAD_Broker_invoked

(The same can be replicated with an empty window title)

Expected Behavior

The window has no title at all as determined by Process Explorer so using wildcard as Window Title and using the hotkey should input in any window that has the current focus

Actual Behavior

Nothing happens

Context

Keepass has this working, but only with wildcard * (tested in Keepass 2.51.1 x64)

KeePassXC - Version 2.7.1 Revision: 5916a8f

Qt 5.15.3 Debugging mode is disabled.

Operating system: Windows 10 Version 2009 CPU architecture: x86_64 Kernel: winnt 10.0.22621

Enabled extensions:

Cryptographic libraries:

Operating System: Windows

phoerious commented 2 years ago

I don' think there is much we can do if there is no title. Just use the search function of the Auto-Type dialog box.

droidmonkey commented 2 years ago

I autotype into this modal window all the time. I think I used the parent windows title, but you have to issue a +{TAB} before typing to refocus the password input.

murder commented 2 years ago

I autotype into this modal window all the time. I think I used the parent windows title, but you have to issue a +{TAB} before typing to refocus the password input.

I honestly don't get the logic, the modal already has focus on it - exactly in the text/input box, can you please double check? that would be nice, I went back to original keepass due to this limitation

droidmonkey commented 2 years ago

Can you screenshot the modal dialog you are trying to type into so I can see if we are talking about two different things...

murder commented 2 years ago

Can you screenshot the modal dialog you are trying to type into so I can see if we are talking about two different things...

This one

droidmonkey commented 2 years ago

Ah OK that is a different dialog then the one I get. You are doing AAD authentication.

murder commented 2 years ago

Ah OK that is a different dialog then the one I get. You are doing AAD authentication.

Yes, it's AAD, but why '*' doesn't work? Gotta check the logic behind original Keepass to see how it handles such situation

murder commented 1 year ago

Hey @droidmonkey - just wondering - why not a 'bug' - it's currently fully supported by origina Keepass using the wildcard '*' Why doesn't it work with the wildcard?

droidmonkey commented 1 year ago

Have you updated to 2.7.4? I believe this is corrected already due to this PR https://github.com/keepassxreboot/keepassxc/pull/7778

When I create an entry with * in the auto-type window match it works perfectly.