search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.27k stars 1.47k forks source link

Feature request: KeePassRPC support #88

Closed soredake closed 7 years ago

soredake commented 8 years ago

Expected Behavior

Having a KeePassRPC support

Current Behavior

No support for KeePassRPC, http://keefox.org/news/detail/2010/03/24/keepassrpc-plugin/.

Possible Solution

Implementing a support.

Context

Your Environment

eversins commented 7 years ago

That would be awesome, since there is no support for Thunderbird at the moment.

phoerious commented 7 years ago

I removed the milestone for now since we are not sure if we actually want our users to expose their passwords over a network protocol with questionable security record. The security of both KeePassHTTP and KeePassRPC is doubtable and in their current state we would prefer not to have them as part of the main KeePassXC product.

This doesn't mean KeePassXC will never support it, it only means that at the moment we don't have immediate plans and an implementation needs further discussion.

Ajedi32 commented 7 years ago

I'd love to see some form of native support for browser integration (whether that be with a HTTP or RPC protocol). It's extremely convenient and protects against one of the most common attacks against password-based logins on the web: phishing.

vanous commented 7 years ago

Thanks for all the work and thanks for the KeePassHTTP integration. Any chance to please add KeePassRPC and also only allow it as a build parameter? The KeeFox extension is superior to the PassIFox imho. I could finally leave mono behind on my linux desktop... (nothing against mono, but in this case...)

phoerious commented 7 years ago

When comparing KeePassHTTP to KeepassRPC, I would probably prefer to have the latter, but we haven't reviewed the KeePassRPC protocol deeply enough yet that we can just integrate and ship it. And on the other hand, KeeFox apparently only targets Firefox but not Chrome.

KeePassHTTP itself already has quite a few flaws which are being discussed in #147 and which we are trying to work around as best we can.

EDIT: I thought we had a pull requests for it already, but apparently we don't.

soredake commented 7 years ago

@phoerious keefox might be rewrited to webextension (api compatible with chrome) https://github.com/luckyrat/KeeFox/issues/728#issuecomment-263219244 @vanous totally agree, i create this issue just because i use keefox and hate mono.

janbuchar commented 7 years ago

Just for the record, the KeePassRPC protocol seems more complicated than KeePassHTTP and it uses some features that are not present in KeePassXC (e.g. password profiles, if I understand correctly). The only "documentation" I know of is the source code - look for methods annotated with [JsonRpcMethod]. It is based on json-rpc, so supporting it is not impossible.

phoerious commented 7 years ago

Closing this in favor of #259 to keep things organized.

ggeorgg commented 6 years ago

In this comment eversins mentioned the support of thunderbird. Can this be done now with the release of KeePassXC-Browser. I have tried to manually install the xpi-file to thunderbird, but it tells me "this add-on could not be installed becaused it seems broken" thunderbird

droidmonkey commented 6 years ago

Maybe? I am not sure how much crossover Thunderbird has with Firefox in terms of plugin functionality. The browser plugin is very focused on filling in form fields on web pages.

ggeorgg commented 6 years ago

OK. I thought that Firefox and Thunderbird had a very similar code base and not that much effort needs to be taken to realize this. Actually I was thinking about switching from Keepass to Keepassxc.